Test Collection API on deleted database #114
Conversation
| @Test | ||
| fun testAddChangeListenerToCollectionInDeletedDatabase() { | ||
| deleteDb(baseTestDb) | ||
| testCollection.addChangeListener(testSerialExecutor) {} |
There was a problem hiding this comment.
Prolly leave the explicit executor out. I think it is irrelevant...
| // Test that addDocumentChangeListener to a collection in a deleted database doesn't throw an exception | ||
| @Test | ||
| fun testAddDocumentChangeListenerToCollectionInDeletedDatabase() { | ||
| val docID = "testDoc" |
There was a problem hiding this comment.
Why do you need to save a doc, here? .... or specify an executor? KIS (just one 'S'!!!)
| } | ||
|
|
||
| try { | ||
| testCollection.save(MutableDocument(doc1Id)) |
There was a problem hiding this comment.
Again... I don't think these documents add anything. You are just testing the deleted database. I think there's way to much code here...
| deleteDb(baseTestDb) | ||
| assertEquals(0, testCollection.count) | ||
| } | ||
|
|
||
| // Test getting doc count from a collection deleted in a different database instance returns 0 | ||
| @Test | ||
| fun testGetDocFromCollectionDeletedInADifferentDBInstance() { | ||
| val otherDatabase = duplicateDb(baseTestDb) |
There was a problem hiding this comment.
Fwiw, here, you could just say:
duplicateDb(baseTestDb).use { ... }
| val doc = MutableDocument(docID) | ||
| saveDocInTestCollection(doc) | ||
| otherDatabase.use { | ||
| val docID = "doc1" |
There was a problem hiding this comment.
You could do this outside the use. It doesn't have anything to do with the db.
| val docID = "doc1" | ||
| val doc = MutableDocument(docID) | ||
| saveDocInTestCollection(doc) | ||
| otherDatabase.deleteCollection(testCollection.name, testCollection.scope.name) |
There was a problem hiding this comment.
Inside the use block, otherDatabase is called "it"
|
|
||
| testCollection.delete(doc) | ||
| otherDb.use { | ||
| val doc = createSingleDocInCollectionWithId("doc") |
There was a problem hiding this comment.
I think creating the doc can come out of the use
| testCollection.createIndex("index1", ValueIndexConfiguration("firstName", "lastName")) | ||
| assertEquals(1, testCollection.indexes.size) | ||
| // Delete collection | ||
| otherDb.deleteCollection(testCollection.name, testCollection.scope.name) |
There was a problem hiding this comment.
Have a look at Kotlin "scoping functions". Again... otherDb should be called 'it' here.
| @@ -97,7 +96,15 @@ class CollectionTest : BaseCollectionTest() { | |||
| @Test(expected = CouchbaseLiteException::class) | |||
| fun testGetDocFromCollectionInClosedDB() { | |||
| createSingleDocInCollectionWithId("doc_id") | |||
There was a problem hiding this comment.
Maybe this should be named createSingleDocInTestCollection?
| // Test getting doc count from a collection in a deleted database returns 0 | ||
| @Test | ||
| fun testGetDocCountFromCollectionInDeletedDatabase() { | ||
| val docID = "doc_id" |
There was a problem hiding this comment.
Do you want to use saveSingleDocInCollectionWithID (or, the renamed version) here?
and some refactoring to safely close db.