Test Collection API on deleted database #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to close db safely
bmeike
approved these changes
Aug 17, 2022
| var changes: MutableList<String>? = null | ||
| var latch: CountDownLatch? = null | ||
|
|
||
| val token = testCollection.addChangeListener() { c -> |
There was a problem hiding this comment.
If you create a token you have to remove() it in a finally clause....
| @@ -239,7 +239,7 @@ public void testSaveThenGetFromAnotherDB() throws CouchbaseLiteException { | |||
| assertNotSame(doc1a, doc1b); | |||
| assertEquals(doc1a.getId(), doc1b.getId()); | |||
| assertEquals(doc1a.toMap(), doc1b.toMap()); | |||
| anotherDb.close(); | |||
| closeDb(anotherDb); | |||
There was a problem hiding this comment.
I think you need to do this in a finally clause...
|
|
||
| anotherDb.close(); | ||
| closeDb(anotherDb); |
| try { | ||
| String id = "doc_id"; | ||
| MutableDocument document = new MutableDocument(id); | ||
| deleteDb(baseTestDb); |
There was a problem hiding this comment.
This test can fail in VERY misleading ways. The deleteDb could throw a CBLException that is not the right kind. that would cause the test to fail, but for the entirely wrong reason. Move everything that isn't being tested outside the try block. You'll have to add CBLException to the signature.
…e to avoid merge conflict
|
too many conflicts, will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to close db safely