Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rest of collection tests #107

Merged
merged 2 commits into from
Aug 3, 2022
Merged

The rest of collection tests #107

merged 2 commits into from
Aug 3, 2022

Conversation

LaurenNguyen14
Copy link
Contributor

No description provided.

Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

@@ -382,7 +382,8 @@ class CollectionTest : BaseCollectionTest() {
}
TestUtils.assertThrowsCBL(CBLError.Domain.CBLITE, CBLError.Code.NOT_FOUND) {
testCollection.delete(
doc1b!!)
doc1b!!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the wrapped?

@Test(expected = CouchbaseLiteException::class)
fun testCreateCollectionNameLength252() {
val name =
"fhndlbjgjyggvvnreutzuzyzszqiqmbqbegudyvdzvenpybjuayxssmipnpjysyfldhjmyyjmzxhegjjqwfrgzkwbiepqbvwbijcifvqamanpmiqydqpcqgubyputmrjiulrjxbayzpxqbxsaszkdxdobhreeqorlmfeoukbspfocymiucffsvioqmvqpqnpvdhpbnenkppfogruvdrrhiaalcfijifapsjqpjuwmlkkrxohvgxoqumkktipsqpsgrqidtcdeadnanxlhbivyvqkdxprsjybvuhjolkpaswlkgtiz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice!!!


@Test
fun testScopeNameContainingIllegalChars() {
val array = charArrayOf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should define this as a constant, up at the top of the test?

@LaurenNguyen14 LaurenNguyen14 merged commit 2af618c into master Aug 3, 2022
@LaurenNguyen14 LaurenNguyen14 deleted the fix/CBL-3517 branch August 3, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants