Fix QueryTest.testWhereValued() #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeike
force-pushed
the
master
branch
2 times, most recently
from
dbfab0e
to
bb3027b
Compare
jeffdgr8
force-pushed
the
fix/test-where-valued
branch
from
38e0b6c
to
8b6c5c8
Compare
|
Fix in 3.1 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
QueryTest.testWhereNullOrMissing()test caseTestCase(address.notNullOrMissing(), 2)becameTestCase(address.isNotValued(), 2)intestWhereValued()which should be incorrect, but the test was still passing. Correcting it asTestCase(address.isValued(), 2)passed as well. On further inspection, the<should actually be<=, which properly causes the current state to fail and the corrected to pass.