CBL-5894 : Update IndexUpdater API and sync illegal behavior #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Test 27. TestIndexUpdaterUseAfterFinished * Merged Test 26 into Test 27.
* Updated IndexUpdater API to sync illegal behavior with the other platforms : If functions have out error, return out error; otherwise abort. * Updated LazyVectorIndex tests * Used LiteCore 3.2.0-210
|
Code Coverage Results:
|
borrrden
reviewed
Jun 28, 2024
| auto value = CBLIndexUpdater_Value(updater, i); | ||
| CHECK(!value); | ||
| } | ||
| // Note: These two functions cannot be tested as they will abort when index is out-of-bound. |
There was a problem hiding this comment.
We made this undefined behavior now, so really there is no reason to test this. It's not legal to do and that means the behavior is "whatever".
There was a problem hiding this comment.
Agreed. Will remove it in later commit.
borrrden
approved these changes
Jun 28, 2024
|
You really should branch if you are going to use the release/3.2 branch of Core |
|
Will branch it very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated IndexUpdater API to sync illegal behavior with the other platforms : If functions have out error, return out error; otherwise abort.
Added TestIndexUpdaterUseAfterFinished.
Used LiteCore 3.2.0-210