Remove the ability to store env (and kids) inside couchapp.json
#200
Comments
|
i think it's reasonable for carrying something like hooks and vendor handler via Maybe we can consider some trade-off: just prevent |
|
@BigBlueHat I will implement the trade-off version if #176 completes. |
iblislin
added a commit
that referenced
this issue
Jan 10, 2016
We will ignore the whole `env` field in `couchapp.json`, and show some warnings.
|
@BigBlueHat please try out branch issue-200 :) |
|
Perfect! Great thinking on the warning message--and having the details of where the information should go. Super fab! 💃 |
|
I will document this and send PR in few days later. :) |
|
❤️ |
iblislin
added a commit
that referenced
this issue
Jan 13, 2016
iblislin
added a commit
that referenced
this issue
Jan 13, 2016
We will ignore the whole `env` field in `couchapp.json`, and show some warnings.
iblislin
added a commit
that referenced
this issue
Jan 13, 2016
iblislin
added a commit
that referenced
this issue
Jan 19, 2016
[#200] Prevent user from placing `env` in `couchapp.json`
|
Merged via f2955e9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Until this PR #195, I had no idea one could put
envcontents incouchapp.json. This seems to invite risk of publishing more than one wants--putting public facing content (name, description) content next to private, unencrypted content (env.default.db, etc.).I'd propose we remove
couchapp.jsonfromconfig.pyline 65.The text was updated successfully, but these errors were encountered: