Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections)!: remove dependency on SDK #14324

Merged
merged 5 commits into from
Dec 15, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Dec 15, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kocubinski kocubinski self-assigned this Dec 15, 2022
collections/map.go Outdated Show resolved Hide resolved
// Ex:

// NewSchemaFromAccessor(func(ctx context.Context) store.KVStore {
// return sdk.UnwrapSDKContext(ctx).KVStore(kvStoreKey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to export a function in sdk/types like this to facilitate adoption?

func SdkContextSchemaAccessor(storeKey store.StoreKey) func(ctx context.Context) store.KVStore {
	return func(ctx context.Context) store.KVStore {
		return sdk.UnwrapSDKContext(ctx).KVStore(storeKey)
	}
}

Copy link
Member Author

@aaronc aaronc Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that could be added to types if it's useful. Either way the function is pretty small. Can that be a separate PR if people want it?

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aaronc aaronc enabled auto-merge (squash) December 15, 2022 21:26
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

[Cosmos SDK - Collections] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aaronc aaronc merged commit 175de85 into main Dec 15, 2022
@aaronc aaronc deleted the aaronc/collections-remove-sdk-dep branch December 15, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants