refactor!(collections): don't panic when initializing collections #14323
Conversation
| for prefix := range s.schema.collectionsByPrefix { | ||
| for prefix2 := range s.schema.collectionsByPrefix { | ||
| // don't compare the prefix to itself | ||
| if prefix == prefix2 { | ||
| continue | ||
| } | ||
|
|
||
| // if one prefix is the prefix of the other we have an overlap and | ||
| // this schema is corrupt | ||
| if strings.HasPrefix(prefix, prefix2) { | ||
| return Schema{}, fmt.Errorf("schema has overlapping prefixes 0x%x and 0x%x", prefix, prefix2) | ||
| } | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
| for prefix2 := range s.schema.collectionsByPrefix { | ||
| // don't compare the prefix to itself | ||
| if prefix == prefix2 { | ||
| continue | ||
| } | ||
|
|
||
| // if one prefix is the prefix of the other we have an overlap and | ||
| // this schema is corrupt | ||
| if strings.HasPrefix(prefix, prefix2) { | ||
| return Schema{}, fmt.Errorf("schema has overlapping prefixes 0x%x and 0x%x", prefix, prefix2) | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
| } | ||
|
|
||
| schema := *s.schema | ||
| s.schema = nil // this makes the builder unusable |
There was a problem hiding this comment.
maybe an explicit panic check is better to debug than a nil pointer dereference I think
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
|
[Cosmos SDK - Collections] Kudos, SonarCloud Quality Gate passed!
|
Description
This changes the collections API to not panic because of schema errors by using a builder pattern, addressing #14267 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change