Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/v2/cometbft commands should support both json and yaml output #20495

Closed
Tracked by #20439
kocubinski opened this issue May 30, 2024 · 1 comment · Fixed by #20670
Closed
Tracked by #20439

server/v2/cometbft commands should support both json and yaml output #20495

kocubinski opened this issue May 30, 2024 · 1 comment · Fixed by #20670
Labels
C:server/v2 Issues related to server/v2

Comments

@kocubinski
Copy link
Member

kocubinski commented May 30, 2024

see these TODOs (and possibly others).

// return clientCtx.PrintProto(blocks) // TODO: previously we had this, but I think it can be replaced with a simple json marshal.
// We are missing YAML output tho.
bz, err := protojson.Marshal(blocks)

// TODO: figure out yaml and json output

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 30, 2024
@tac0turtle tac0turtle added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels May 31, 2024
@facundomedica
Copy link
Member

I do remember these comments now. I think it was that we were previously using the codec for json. Then the YAML I think it was just a matter of having an output flag there, which previously was being imported from the sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants