-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic]: server/v2 production readiness via simapp/v2 and testing #20439
Labels
T:Epic
Epics
Comments
This was referenced May 31, 2024
Merged
This was referenced Jun 19, 2024
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent PRs (including #20412) have introduced server/v2 infrastructure and an example app, simapp/v2, using this code. In short server/v2 is a decomposition of baseapp and friends into modular, composable, parts. What is merged into
main
at the time of writing this issue should be considered a functional PoC. Completion of the issues enumerated here will harden the code quality of server/v2 and elevate it from PoC to production ready.Testing
For comprehensive testing, we should adapt all integration, e2e, and sims tests currently covering runtime/v1 for runtime/v2. Perhaps the clever use of a build flag and interfaces in the right places could make this easier.
BaseApp
. Is it possible for this function to accept an abstraction which both BaseApp and something from runtime/v2 satisfy?cosmos-sdk/server/v2/cometbft/abci_test.go
Line 3 in 5bf88be
Breaking
panic: proto:not found
when using go.mod replaces instead of go.work #20492cosmos-sdk/scripts/simapp-v2-init.sh
Line 25 in 5bf88be
server_modular
) and possibly follow up PRs around TxValidators must be rebased onto mainsdk.Context
is not provided by runtime/v2, but required for certain tx handlers using gogo interface types Environment in context #19640Feature Parity
ServerModule
, i.e. comet node as a module, api server as a module, etc.cosmos-sdk/server/v2/server.go
Line 16 in 5bf88be
"app", "store", "p2p", "custom"
are not yet implemented #20494Code quality
cosmos-sdk/server/v2/stf/core_router_service.go
Lines 98 to 105 in 5bf88be
STF Todos
The text was updated successfully, but these errors were encountered: