This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
systemd: don't fsck OEM partition in a container or on PXE systems #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various units pull in usr-share-oem.mount, including coreos-setup-environment.service. usr-share-oem.mount is skipped when there's no OEM partition, but systemd still pulls in its dependencies in that case and will fail usr-share-oem.mount if those dependencies fail. 8f6dca0 therefore caused unit failures. Fix them by making the corresponding systemd-fsck@ unit subject to the same conditions as usr-share-oem.mount.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various units pull in
usr-share-oem.mount, includingcoreos-setup-environment.service.usr-share-oem.mountis skipped when there's no OEM partition, but systemd still pulls in its dependencies inthat case and will fail
usr-share-oem.mountif those dependencies fail. 8f6dca0 therefore caused unit failures. Fix them by making the correspondingsystemd-fsck@unit subject to the same conditions asusr-share-oem.mount.This only works because we already have a
dev-disk-by\x2dlabel-OEM.deviceunit with the same set of conditions. There's no similar device unit for/bootand that doesn't lead to any unit failures, so clearly nothing is pulling in/booton PXE systems. This PR therefore doesn't conditionalize thesystemd-fsck@unit for/boot.Addresses coreos/bugs#2342.