This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
systemd: fsck EFI-SYSTEM and OEM; drop unnecessary OEM mount option #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is left over from the ChromeOS stateful partition. There's little need to reduce the OEM filesystem's sync timer to 10 minutes, since the filesystem is almost never written to, and when writes do occur it may be surprising if they aren't committed for 10 minutes.
If the filesystem ever had the error flag set (OEM) or was uncleanly
unmounted (EFI-SYSTEM), we were never actually fixing it. Fixes kernel
message after unclean shutdown:
FAT-fs (vda1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck.
This pulls in systemd-fsck using Requires rather than Wants, since
that's what systemd-fstab-generator does. As a result, this change
will induce mount failures on any machines with ESP or OEM filesystems
which are irreparable but somehow still mountable. Those machines have
problems anyway, and it's better to detect them rather than continuing
in the face of arbitrary filesystem corruption.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses coreos/bugs#2245.