This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
removed auto-adding v to the etcd image version #2079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an
etcdCluster
resource, you provide anImage
and aVersion.
Version` is a semver version depending on the EtcD image version you wish to use.The default is to use Quay images, which are versioned using a pattern of
v
+semver
, likev3.0.12
.So defining :
Will create a Pod using image
quay.io/coreos/etcd:v3.1.10
.This may be fine with
Quay
images, but when you are working with other Docker Registries, you may not want to add thev
to the version.The Operator should not force you to use a specific version pattern.
This PR removes the
v
addition to the version, allowing to use a real version name in the CRD.