Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require stringio explicitly for Ruby >= 2.7 #98

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Require stringio explicitly for Ruby >= 2.7 #98

merged 1 commit into from
Mar 17, 2021

Conversation

eagletmt
Copy link
Member 

% RBENV_VERSION=2.6.6 bundle exec ruby -e "require 'aws/xray/sockets'"
% RBENV_VERSION=2.7.2 bundle exec ruby -e "require 'aws/xray/sockets'"
Traceback (most recent call last):
        4: from -e:1:in `<main>'
        3: from -e:1:in `require'
        2: from /home/eagletmt/.clg/github.com/cookpad/aws-xray/lib/aws/xray/sockets.rb:1:in `<top (required)>'
        1: from /home/eagletmt/.clg/github.com/cookpad/aws-xray/lib/aws/xray/sockets.rb:2:in `<module:Aws>'
/home/eagletmt/.clg/github.com/cookpad/aws-xray/lib/aws/xray/sockets.rb:12:in `<module:Xray>': uninitialized constant StringIO (NameError)

@eagletmt
Require stringio explicitly for Ruby >= 2.7
3c41208 
```
% RBENV_VERSION=2.6.6 bundle exec ruby -e "require 'aws/xray/sockets'"
% RBENV_VERSION=2.7.2 bundle exec ruby -e "require 'aws/xray/sockets'"
Traceback (most recent call last):
        4: from -e:1:in `<main>'
        3: from -e:1:in `require'
        2: from /home/eagletmt/.clg/github.com/cookpad/aws-xray/lib/aws/xray/sockets.rb:1:in `<top (required)>'
        1: from /home/eagletmt/.clg/github.com/cookpad/aws-xray/lib/aws/xray/sockets.rb:2:in `<module:Aws>'
/home/eagletmt/.clg/github.com/cookpad/aws-xray/lib/aws/xray/sockets.rb:12:in `<module:Xray>': uninitialized constant StringIO (NameError)
```
@eagletmt eagletmt merged commit 5083b6c into cookpad:master Mar 17, 2021
@eagletmt eagletmt deleted the fix-for-ruby27 branch March 17, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eagletmt