Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept new monaco-editor versions #13

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Feb 9, 2021

It seems there is still no incompatibility between monaco-collab-ext and the new monaco-editor version

@CGNonofr
Copy link
Contributor Author

@mmacfadden Can you have a look at it?

I made it accept all future version to not have to create a PR after each monaco update (since it's pretty rare that it breaks this extension)

@mmacfadden
Copy link
Contributor

Sure thing I will take a look today.

@CGNonofr
Copy link
Contributor Author

(just a little ping)

@mmacfadden mmacfadden merged commit d221975 into convergencelabs:master Feb 23, 2021
@mmacfadden mmacfadden self-assigned this Feb 23, 2021
@mmacfadden
Copy link
Contributor

Thanks! I will release a new version shortly.

@CGNonofr
Copy link
Contributor Author

Is it possible to release it to npmjs?

@mmacfadden
Copy link
Contributor

Hey I can do that this week.

@mmacfadden
Copy link
Contributor

Just released this to npmjs. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants