Skip to content

Commit

Permalink
style: 优化登录用户信息角色相关信息命名
Browse files Browse the repository at this point in the history
1.roles => roleCodes
2.roleSet => roles
  • Loading branch information
Charles7c committed Sep 1, 2023
1 parent d20aadf commit be394f3
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public Expression getSqlSegment(Expression where, String mappedStatementId) {
*/
private static Expression buildDataScopeFilter(LoginUser user, String tableAlias, Expression where) {
Expression expression = null;
for (RoleDTO role : user.getRoleSet()) {
for (RoleDTO role : user.getRoles()) {
DataScopeEnum dataScope = role.getDataScope();
if (DataScopeEnum.ALL.equals(dataScope)) {
return where;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ public class LoginUser implements Serializable {
/**
* 角色编码集合
*/
private Set<String> roles;
private Set<String> roleCodes;

/**
* 角色集合
*/
private Set<RoleDTO> roleSet;
private Set<RoleDTO> roles;

/**
* 令牌
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ public List<String> getPermissionList(Object loginId, String loginType) {
@Override
public List<String> getRoleList(Object loginId, String loginType) {
LoginUser loginUser = LoginHelper.getLoginUser();
return new ArrayList<>(loginUser.getRoles());
return new ArrayList<>(loginUser.getRoleCodes());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ public String login(String username, String password) {
// 登录
LoginUser loginUser = BeanUtil.copyProperties(user, LoginUser.class);
loginUser.setPermissions(permissionService.listPermissionByUserId(userId));
loginUser.setRoles(permissionService.listRoleCodeByUserId(userId));
loginUser.setRoleSet(roleService.listByUserId(userId));
loginUser.setRoleCodes(permissionService.listRoleCodeByUserId(userId));
loginUser.setRoles(roleService.listByUserId(userId));
LoginHelper.login(loginUser);

// 返回令牌
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public List<LoginUser> list(OnlineUserQuery query) {
public void cleanByRoleId(Long roleId) {
List<LoginUser> loginUserList = this.list(new OnlineUserQuery());
loginUserList.parallelStream().forEach(u -> {
if (u.getRoleSet().stream().anyMatch(r -> r.getId().equals(roleId))) {
if (u.getRoles().stream().anyMatch(r -> r.getId().equals(roleId))) {
try {
StpUtil.logoutByTokenValue(u.getToken());
} catch (NotLoginException ignored) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public R<UserInfoVO> getUserInfo() {
UserDetailVO userDetailVO = userService.get(loginUser.getId());
UserInfoVO userInfoVO = BeanUtil.copyProperties(userDetailVO, UserInfoVO.class);
userInfoVO.setPermissions(loginUser.getPermissions());
userInfoVO.setRoles(loginUser.getRoles());
userInfoVO.setRoles(loginUser.getRoleCodes());
return R.ok(userInfoVO);
}

Expand Down

0 comments on commit be394f3

Please sign in to comment.