Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Load correct route on initial load #1

Merged
merged 3 commits into from
Jul 29, 2016
Merged

Load correct route on initial load #1

merged 3 commits into from
Jul 29, 2016

Conversation

lynnagara
Copy link
Contributor

App is routed to the correct page on initial load. Python server always returns index.html and routing is handled by the front end.

@Khaledgarbaya Khaledgarbaya self-assigned this Jul 29, 2016
@Khaledgarbaya
Copy link
Contributor

Khaledgarbaya commented Jul 29, 2016

Hey @lynnagara,
Looking Good but one more thing when we host the project in Github pages we need to redirect the the 404 to the index.html.
You can do that by adding cp $PAGES_DIR/index.html $PAGES_DIR/404.html at publish.sh:21

@lynnagara
Copy link
Contributor Author

yo @Khaledgarbaya - added that line!

@Khaledgarbaya
Copy link
Contributor

LGTM 🚢

@Khaledgarbaya Khaledgarbaya merged commit 43bfd38 into contentful:master Jul 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants