Remove random wait at controller startup #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf61df6
to
1a083b1
Compare
yannh
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changing and why?
Remove the initial random waiting period before the controller starts polling the AWS API.
This was originally added because some users may run multiple instances of this controller, and if they all started up at the same time, they may exhaust the AWS SecretsManager API rate limits, which used to be much lower. The API ratelimits are now considerably elevated, plus there is an expontential backoff retry mechanism in place.
In case someone wants to orchestrate the startup of multiple controllers, they should do it in the kubernetes manifests.
This change also makes it quicker to develop kube-secret-syncer (because there is no waiting time for logs to appear).