Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #554

Merged
merged 1 commit into from
May 29, 2020
Merged

Fix typos #554

merged 1 commit into from
May 29, 2020

Conversation

pgrimaud
Copy link
Contributor

Hi,

This PR will fix :

  • 1 typo in CONTRIBUTING.md
  • 1 typo in docs/private-registries.md
  • 3 typos in scripts/lifecycle-tests.sh

Cheers! 🤖

@simskij
Copy link
Member

simskij commented May 29, 2020

@all-contributors add @pgrimaud for docs

@simskij simskij merged commit bd9246b into containrrr:master May 29, 2020
@allcontributors allcontributors bot mentioned this pull request May 29, 2020
Merged
@allcontributors
Copy link
Contributor

@simskij

I've put up a pull request to add @pgrimaud! 🎉

@piksel
Copy link
Member

piksel commented May 29, 2020

@simskij do you know why the greeting failed?

@zoispag
Copy link
Member

zoispag commented May 29, 2020

@piksel it always fails 😞

@zoispag
Copy link
Member

zoispag commented May 29, 2020 •
edited
Loading

Here's why: actions/first-interaction#10 (comment)

@piksel
Copy link
Member

piksel commented May 29, 2020

Oh wow. That's a bummer.

@simskij
Copy link
Member

simskij commented May 30, 2020

It works on issues though, so maybe we could filter it to that for the time being.

simskij pushed a commit that referenced this pull request Jul 4, 2020
@pgrimaud @simskij
Fix typos (#554)
1eb4d74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piksel piksel piksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgrimaud @simskij @piksel @zoispag