fix creds sync from yaml #1142
Merged
fix creds sync from yaml #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Dec 23, 2020
Pass down the creds from yaml file only if the values are not empty.
Enables to use credentials from other authfiles alternatively.
Signed-off-by: Qi Wang <[email protected]>
mtrmac
approved these changes
Dec 30, 2020
| @@ -280,8 +280,9 @@ func imagesToCopyFromRegistry(registryName string, cfg registrySyncConfig, sourc | |||
| serverCtx.DockerDaemonCertPath = cfg.CertDir | |||
| serverCtx.DockerDaemonInsecureSkipTLSVerify = (cfg.TLSVerify.skip == types.OptionalBoolTrue) | |||
| serverCtx.DockerInsecureSkipTLSVerify = cfg.TLSVerify.skip | |||
| serverCtx.DockerAuthConfig = &cfg.Credentials | |||
|
|
|||
There was a problem hiding this comment.
Absolutely on-blocking nit: Maybe keep the blank line, to visually separate the serverCtx setup from the actual processing?
|
LGTM |
samdoran
added a commit
to ansible/bedrock
that referenced
this pull request
Apr 22, 2021
This was fixed in containers/skopeo#1142. Credentials in auth.json are now used.
mattclay
pushed a commit
to mattclay/bedrock
that referenced
this pull request
May 5, 2022
This was fixed in containers/skopeo#1142. Credentials in auth.json are now used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass down the creds from yaml file only if the values are not empty.
Enables to use credentials from other authfiles alternatively.
close: #1122
Signed-off-by: Qi Wang [email protected]