Support multiple file includes and include cycles in include section #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, include sections had to be lists of size 1 and never properly addressed other sizes. Include cycles were possible to cause infinite loops. This commit supports including multiple compose files and can detect cyclic include behavior. This commit also parses each included file only once as an optimization. Signed-off-by: Jason Yip <[email protected]>
p12tic
requested changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, include sections had to be lists of size 1 and never properly addressed other sizes. Include cycles were possible to cause infinite loops. This commit supports including multiple compose files and can detect cyclic include behavior. This commit also parses each included file only once as an optimization.