packaging: Move version definition to setup.cfg #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unfortunate side-effect of defining the version inside a project's main module is that dependency issues can break installation. In this project, even though pyyaml and python-dotenv are listed in install_requires, installation would fail if either were not present, because the build process requires importing that module. Signed-off-by: Zack Cerza <[email protected]>
|
I would love for the podman-compose.py to be a standalone script too. I don't want to add unnecessary dependencies |
p12tic
reviewed
Mar 9, 2024
| @@ -35,8 +41,6 @@ | |||
| import yaml | |||
| from dotenv import dotenv_values | |||
|
|
|||
| __version__ = "1.0.4" | |||
There was a problem hiding this comment.
I think it was fine if both setup.cfg and podman_compose.py duplicated the version.
The dependency problems is a valid justification to do so. The downside is that these versions can get out of sync. However this can be addressed by having CI run a simple regex based test that extracts versions from files and compares them.
p12tic
requested changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unfortunate side-effect of defining the version inside a project's
main module is that dependency issues can break installation. In this
project, even though pyyaml and python-dotenv are listed in
install_requires, installation would fail if either were not present,
because the build process requires importing that module.
Signed-off-by: Zack Cerza [email protected]