Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent example domains #2069

Merged
merged 1 commit into from Aug 3, 2023
Merged

Use consistent example domains #2069

merged 1 commit into from Aug 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2023

No description provided.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you, @fschwa

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the man page really is inconsistent, but this is actually making it more inconsistent?!

The text immediately below still says .net, so now the text and the example don’t match.

Also, the …-for-example-com name directly refers to the example.com being redirected, so it should probably continue to prefer com over net (Or, alternatively, use a name similar to registry-for-example-com.internal.)


The same examples also exist in the default registries.conf in this repo.

Ideally all of that should be changed to use one host consistent host name.

@ghost
Copy link
Author

ghost commented Aug 2, 2023

You are right. It was kind of drive-by when actually doing something else. Will check for the other occurrences.

@ghost
Copy link
Author

ghost commented Aug 2, 2023

Alright. Updated. ... However, since you are talking about a redirect, might the .net be on purpose? I am not familiar with podman yet, so hard for me to tell.

Signed-off-by: Frederik Schwarzer <[email protected]>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 2869e26 into containers:main Aug 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants