Update x/exp/slices, and some small slice-related cleanups #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and update for the changed API of slices.SortStableFunc. Should not change behavior Signed-off-by: Miloslav Trmač <[email protected]>
Using append without a manual allocation and a copy of the old data has a chance to grow the slice in place, without a sufficiently smart compiler. And it's simpler. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Rely on the test helper instead. (On the 2-element array, we really don't care about performance.) Should not change (test) behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Right now, using slices.SortFunc would not be much shorter. Signed-off-by: Miloslav Trmač <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily replaces #2065 ; also a few other changes found during slice usage audit.
See individual commit messages for details.