Retract the v1.0.0 version #916
Conversation
The v1.0.0 tag no longer exists, but the Go proxy still remembers it. So, we see things like > skopeo % go get -u ./... > go: downloading github.com/containers/image/v5 v5.19.1 > github.com/containers/skopeo/cmd/skopeo imports > github.com/containers/common/pkg/auth: cannot find module providing package github.com/containers/common/pkg/auth > github.com/containers/skopeo/cmd/skopeo imports > github.com/containers/common/pkg/flag: cannot find module providing package github.com/containers/common/pkg/flag > github.com/containers/skopeo/cmd/skopeo imports > github.com/containers/common/pkg/report: cannot find module providing package github.com/containers/common/pkg/report > github.com/containers/skopeo/cmd/skopeo imports > github.com/containers/common/pkg/retry: cannot find module providing package github.com/containers/common/pkg/retry Try to fix that, per https://go.dev/ref/mod#go-mod-file-retract and https://play-with-go.dev/retract-module-versions_go116_en/ . The intent is to tag this commit with v1.0.1 (and then, later, maybe delete it). Signed-off-by: Miloslav Trmač <[email protected]>
|
Hopefully fixes #914 . If this fails, we can never the |
|
LGTM |
There was a problem hiding this comment.
/lgtm
Note that
The retract directive was added in Go 1.16. Go 1.15 and lower will report an error if a retract directive is written in the main module’s go.mod file and will ignore retract directives in go.mod files of dependencies.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh, that’s unfortunate. I guess we are doing that now… |
|
… actually, after we tag the v1.0.1, and assuming that works for recent versions, we could just revert the retraction on the v0.… branch, and if I understand the lookup correctly, that’s going to work fine. But let’s keep things simple and only do that if someone asks for it. |
|
@rhatdan / @vrothberg Could you tag a v1.0.1 tag at commit a970d99 , please? |
|
You want me to push this to containers/common? |
|
Yes, this is a c/common PR and commit, so tag it in this repo. (And then don’t merge updates to a v1.0.1 version of c/common in Podman/Buildah/Skopeo, if this retraction didn’t work and the tools thought that v1.0.1 is a legitimate update.) |
|
The Tag now should exists in containers/common. |
|
Thanks, it seems to work as expected — and containers/podman#13131 was filed by Dependabot. |
|
Great work, @mtrmac ! |
The v1.0.0 tag no longer exists, but the Go proxy still remembers it.
So, we see things like
Try to fix that, per https://go.dev/ref/mod#go-mod-file-retract and https://play-with-go.dev/retract-module-versions_go116_en/ .
The intent is to tag this commit with v1.0.1 (and then, later,
maybe delete it).