libimage: inspect: extract healthchecks from configs #822
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a1d72f2
to
687dbca
Compare
buildkit is setting the health check in the image's config while Docker and Podman set it in the image's container config. Hence, if the container config's healthcheck is nil, have a look at the config. Fixes: #containers/podman/issues/12226 Signed-off-by: Valentin Rothberg <[email protected]>
687dbca
to
af5ad62
Compare
|
@containers/podman-maintainers PTAL |
|
LGTM |
|
/lgtm |
| // NOTE: Health checks may be listed in the container config or | ||
| // the config. |
There was a problem hiding this comment.
(This comment is true but not particularly informative on top of what the code already does. “in the ContainerConfig (e.g. Docker and Podman) or the Config (e.g. buildx)” might be more helpful for future readers.
As long as it is captured in this PR, that’s probably good enough.)
buildkit is setting the health check in the image's config while Docker
and Podman set it in the image's container config. Hence, if the
container config's healthcheck is nil, have a look at the config.
Fixes: #containers/podman/issues/12226
Signed-off-by: Valentin Rothberg [email protected]