Display same error as split #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we vendor that into a podman PR first? |
Luap99
reviewed
Jun 28, 2024
libimage/filters.go
Outdated
| @@ -195,7 +195,7 @@ func (r *Runtime) compileImageFilters(ctx context.Context, options *ListImagesOp | |||
| filter = filterBefore(until) | |||
|
|
|||
| default: | |||
| return nil, fmt.Errorf("unsupported image filter %q", key) | |||
| return nil, fmt.Errorf("invalid image filter %q: must be in the format %q", key, "filter=value or filter!=value") | |||
There was a problem hiding this comment.
Why use static string as arg to the format string?
Just add the filter=value or filter!=value part directly into the format string.
7725596
to
a9ba215
Compare
Partial fix for containers/podman#23120 Working on a fix for this crash, but want same error to come back as non-remote case. Signed-off-by: Daniel J Walsh <[email protected]>
|
@Luap99 @mheon @vrothberg containers/podman#23137 now passes, please merge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for containers/podman#23120
Working on a fix for this crash, but want same error to come back as non-remote case.