libnetwork/netavark: accept metric option for mac/ipvlan #2063
Conversation
This option is also supported by netavark for macvlan and ipvlan networks. Fixes containers#2051 Signed-off-by: Paul Holzinger <[email protected]>
Commit 26fc823 added check for the env var inside the network interface setup code as this is something that is always set by podman. However if you try to run the unit tests as rootless they now always failed as the code assumed we have access to a rootful path. The easy fix is to just fix the test to set the env when running rootless. Signed-off-by: Paul Holzinger <[email protected]>
|
@mheon @containers/podman-maintainers PTAL |
|
Any way to also test that the route added has the metric? Code LGTM though |
|
I added such a test to netavark already containers/netavark#1012 I don't really like to add a ton of "runtime" test for netavark here. |
| @@ -326,6 +326,11 @@ func createIpvlanOrMacvlan(network *types.Network) error { | |||
| return fmt.Errorf("unknown ipvlan mode %q", value) | |||
| } | |||
| } | |||
| case types.MetricOption: | |||
| _, err := strconv.ParseUint(value, 10, 32) | |||
There was a problem hiding this comment.
I am following the style of the rest of the option parsing code with that so I have a slight preference to keep it like this.
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This option is also supported by netavark for macvlan and ipvlan
networks.
Fixes #2051