[skip-ci] RPM: redhat registry config files should be config(noreplace) #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to edit these configs and have those changes persist. Will be needed if users experience issues with using the `lookaside` setting instead of the current `sigstore` setting that these files ship with. Ref: containers#1983 Signed-off-by: Lokesh Mandvekar <[email protected]>
ktdreyer
approved these changes
May 7, 2024
mtrmac
reviewed
May 8, 2024
|
LGTM - if it is desired to be end-user configurable. |
Let's leave it end-user configurable for now given we're not 100% certain if the |
|
LGTM |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ktdreyer, lsm5, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to edit these configs and have those changes persist.
Will be needed if users experience issues with using the
lookasidesetting instead of the currentsigstoresetting that these files ship with.Ref: #1983