Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Packit: fix copr name #1982

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 6, 2024

The copr name got mistakenly changed during a replace-all in #1960.

@lsm5
Copy link
Member Author

lsm5 commented May 6, 2024

@edsantiago @Luap99 @mheon PTAL

@lsm5 lsm5 marked this pull request as draft May 6, 2024 16:49
The copr name got mistakenly changed during a replace-all in containers#1960.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 marked this pull request as ready for review May 6, 2024 16:50
@edsantiago
Copy link
Collaborator

I don't know what that's doing, so I'm really not the best person to review. I'll just trust you that this is the right thing to do.

@lsm5
Copy link
Member Author

lsm5 commented May 6, 2024

I don't know what that's doing, so I'm really not the best person to review. I'll just trust you that this is the right thing to do.

I can update the commit message. That's the job that triggers builds on podman-next copr after every upstream commit to main branch. I had done a search-and-replace-all in the earlier commit so podman got replaced by containers-common.

@edsantiago
Copy link
Collaborator

No, I think I understand the change, it's just that this is way above my comprehension. As long as it works, it shouldn't need to be touched often, so I'm okay with it.

Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@Luap99
Copy link
Member

Luap99 commented May 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5b6197d into containers:main May 7, 2024
12 checks passed
@lsm5 lsm5 deleted the fix-copr branch May 7, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants