Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config: add new healthcheck_events field #1959

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Apr 17, 2024

Some users wish to turn of healthcheck events in Podman so add a config
option to allow that. The actual logic must live in Podman.

Link: https://issues.redhat.com/browse/RHEL-18987

There is no merge Merge() function and I couldn't find it in the git log
either so just remove the comment.

Signed-off-by: Paul Holzinger <[email protected]>
Some users wish to turn of healthcheck events in Podman so add a config
option to allow that. The actual logic must live in Podman.

Link: https://issues.redhat.com/browse/RHEL-18987

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented Apr 18, 2024

@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Apr 19, 2024

Typo in commit message but not worth re-spinning
LGTM

@mheon
Copy link
Member

mheon commented Apr 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit deb3eee into containers:main Apr 19, 2024
7 checks passed
@Luap99 Luap99 deleted the healthcheck-event branch April 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants