[v0.57 backport] containers.conf: add crun-vm as a runtime #1930
Conversation
Signed-off-by: Lokesh Mandvekar <[email protected]> This is required for podman v4.9 to use crun-vm on F38/39. (cherry picked from commit 7b056a0) Signed-off-by: Lokesh Mandvekar <[email protected]>
docs/containers.conf.5.md
Outdated
| @@ -753,17 +753,17 @@ Indicates whether the application should be running in remote mode. This flag mo | |||
|
|
|||
| Default OCI specific runtime in runtimes that will be used by default. Must | |||
| refer to a member of the runtimes table. Default runtime will be searched for | |||
| on the system using the priority: "crun", "runc", "kata". | |||
| on the system using the priority: "crun", "crun-vm", "runc", "kata". | |||
There was a problem hiding this comment.
I don't think crun-vm should ever be used as a default runtime, as it requires very particular containers and doesn't run them the way other runtimes would.
There was a problem hiding this comment.
Shouldn't be an issue as people should be able to edit defaults in containers.conf. And I imagine unless crun-vm is installed, this issue also won't occur to begin with. @rhatdan wdyt?
There was a problem hiding this comment.
runc should have priority over crun-vm, but I agree that we should not be defaulting to crun-vm.
There was a problem hiding this comment.
in that case, we need to close this one, make these changes on main and then cherrypick to v0.57.
And if I'm reading default.go file correctly, crun-wasm also currently has priority over runc. Should that be changed as well while we're at it?
There was a problem hiding this comment.
PTAL #1941 . If that looks ok, I'll add the commit here too.
Signed-off-by: Lokesh Mandvekar <[email protected]> (cherry picked from commit de2ac28) Signed-off-by: Lokesh Mandvekar <[email protected]>
|
PTAL now. Included cherrypick of #1941 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is required for podman v4.9 to use crun-vm on F38/39.
(cherry picked from commit 7b056a0)
@rhatdan @TomSweeneyRedHat @Luap99 @mheon PTAL
cc @albertofaria