Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump VMs to 2024-03-20 #1928

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

edsantiago
Copy link
Collaborator

...and remove the "dnf install podman-plugins", that package no longer exists.

[takeover of #1927 because manual intervention is needed]

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Mar 21, 2024

@edsantiago my quick guess would be dnsname (podman-plugins rpm) missing

@edsantiago
Copy link
Collaborator Author

Yes, agreed. And it's going to be tricky to fix, but this is entirely on me. Thanks. (The conmon and netavark PRs, those are beyond me)

@Luap99
Copy link
Member

Luap99 commented Mar 21, 2024

The errors look weird, but I think all these tests depend on dnsname in some way. I am fine skipping/removing the dnsname requirement from these test if we no longer have it in newer fedora versions

@edsantiago
Copy link
Collaborator Author

History: CI VMs used to download podman-plugins.rpm. There was no explanation of why, and podman-plugins does not exist on rawhide, so I removed this step from the CI VMs. Today I discover that this repo is why that step existed.

I think the long-term solution is to remove CNI testing but I'm not comfortable doing that here. I will find a way to install plugins.

...and remove the "dnf install podman-plugins", that package
no longer exists.

Signed-off-by: Ed Santiago <[email protected]>
@Luap99
Copy link
Member

Luap99 commented Mar 21, 2024

I think the long-term solution is to remove CNI testing but I'm not comfortable doing that here. I will find a way to install plugins.

Agreed and I explicitly wanted to keep the cni tests alive here since the main code for that is here and we still support it for a while in RHEL 9. Given we regularly get dependency updates to the cni code I like to ensure the code at least still functions on basic level.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 917b62b into containers:main Mar 22, 2024
7 checks passed
@edsantiago edsantiago deleted the bump_vms branch March 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants