Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only try each package format once #1926

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

afbjorklund
Copy link
Contributor

@afbjorklund afbjorklund commented Mar 20, 2024

If there is a "slow" and a "quick" program (not missing), do not look for the package again (if it is not there).

Fixes #1924

Each call to dpkg takes a second, and it is especially bad when installing from source instead of from packages...

If there is a "slow" and a "quick" program (not missing),
do not look for the package again (if it is not there).

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund
Copy link
Contributor Author

Test program:

$ more cmd/version/main.go 
package main

import
(
	"os"
	"fmt"

	"github.com/containers/common/pkg/version"
)

func main() {
	if len(os.Args) < 2 {
		panic("missing path")
	}
	fmt.Printf("%s\n", version.Package(os.Args[1]))
}
$ time ./main /usr/local/libexec/podman/slirp4netns

@rhatdan
Copy link
Member

rhatdan commented Mar 21, 2024

/approve
LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a9dd533 into containers:main Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not try again with "slow" queryPackageVersion, after failing to find with "fast"
3 participants