manifests: preserve Annotations when adding from indexes #1917
+39
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
force-pushed
the
index-add-annotations
branch
3 times, most recently
from
c32923c
to
f4fe6b7
Compare
Luap99
reviewed
Mar 20, 2024
libimage/manifests/manifests.go
Outdated
| @@ -547,6 +556,8 @@ func (l *list) Add(ctx context.Context, sys *types.SystemContext, ref types.Imag | |||
| OSFeatures: append([]string{}, platform.OSFeatures...), | |||
| Size: instance.Size, | |||
| ArtifactType: instance.ArtifactType, | |||
| Annotations: mapToSlice(instance.Annotations), | |||
| URLs: slices.Clone(instance.URLs), | |||
There was a problem hiding this comment.
is there a reason for the clone? I cannot see anything modifying the slice so I don't think clone is needed.
When adding items from one index into another, preserve the annotations and URLs which are set in the descriptors in the source index. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
index-add-annotations
branch
from
f4fe6b7
to
1b7b86a
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding items from one index into another, preserve the annotations and URLs which are set in the descriptors in the source index.