Bump c/storage to v1.53.0, c/image to v5.30.0, and common to v0.58.0, then to v0.59.0-dev #1886
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
Lint failing No idea what this means but it also failed on #1885 |
b2a5fbd
to
4910a35
Compare
|
still failing 😞 |
|
I've rebased, repushed after #1889 from @Luap99 was merged, and still I'm seeing the same error it appears. |
|
I can take a closer look tomorrow morning if you haven't been able to figure it out by then. |
|
I have manually deleted caches matching |
|
@TomSweeneyRedHat I’ll need to leave this for today, one possible avenue to explore. golangci/golangci-lint#1920 suggests a Go version mismatch as a possibility — the lint is running Go 1.19, while |
|
It does look like go-1.21 is the next step, but that might mean having to use Cirrus instead of GitHub Actions. |
This PR in c/common: containers/common#1886 is failing. The best I can figure out, something in c/image is causes lint to error out without much information. I'm trying to add the same linters that c/common uses to this repo to see if it will find what's what. Do not Merge this at this time. [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
As the title says. The third step in the vendor dance. Bumps c/storage v1.53.0 and c/image to v5.30.0 all in preparation of Podman v5.0 [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
As the title says. In preparation of Podman v5.0, bumping to v0.58.0. [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
As the title say, bumping to the next dev version. [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
4910a35
to
3428c9a
Compare
|
Repushed, and through the lint test! |
|
/lgtm |
The third vendor dance step for Podman v5.0.
Bump c/storage to v1.53.0, c/image to v5.30.0, and then c/common to v0.58.0. Finally bump common to a dev branch
[NO NEW TESTS NEEDED]