libimage.ManifestList: add AddArtifact() #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nalind
commented
Feb 13, 2024
nalind
commented
- Add a libimage.ManifestList.AddArtifact() method.
- Add IndexAnnotations and Subject to libimage.ManifestListAnnotateOptions, for setting annotations on the index itself, and the index's subject, respectively.
- In libimage/manifests.list.AddArtifact(), if the subject has an artifactType in its manifest, add its value to the subject descriptor.
vrothberg
reviewed
Feb 13, 2024
nalind
force-pushed
the
more-fun-with-artifacts
branch
2 times, most recently
from
37f596d
to
4f88c9f
Compare
* Add a libimage.ManifestList.AddArtifact() method. * Add IndexAnnotations and Subject to libimage.ManifestListAnnotateOptions, for setting annotations on the index itself, and the index's subject, respectively. * In libimage/manifests.list.AddArtifact(), if the subject has an artifactType in its manifest, add its value to the subject descriptor. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
more-fun-with-artifacts
branch
from
4f88c9f
to
cf3acdc
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.