Handle multiple artifacts correctly #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When saving artifacts to OCI layout directories to use as supplemental refernces, use a different directory for each artifact(!) When supplementing a reference in CopySpecificImages mode, only mark a supplemental reference as the source for a specified instance if it actually corresponds to the instance's digest. If an artifact manifest doesn't have any file layers, remember to catalog the empty descriptor that we add to its layer list to keep it from being empty, as recommended. Extend libimage/manifests.TestReference() to ensure that we're able to copy everything that we should be able to copy. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
multiple-artifacts
branch
from
1dfa66c
to
f0557f0
Compare
|
Oof, took a while to find a flake in the unit test that this extends. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving artifacts to OCI layout directories to use as supplemental references, use a different directory for each artifact(!)
When supplementing a reference in CopySpecificImages mode, only mark a supplemental reference as the source for a specified instance if it actually corresponds to the instance's digest.
If an artifact manifest doesn't have any file layers, remember to catalog the empty descriptor that we add to its layer list to keep it from being empty, as recommended.
Extend libimage/manifests.TestReference() to ensure that we're able to copy everything that we should be able to copy.