API support for managing and tracking artifact manifests in image indexes #1833
Commits on Feb 5, 2024
-
pkg/manifests.list.preferOCI(): pay attention to annotations in indexes
Account for the presence of annotations in the OCI version of an index or list when deciding if the structure should be saved in OCI format. This requires removing an annotation from the test data so that the presence of "features" information for one of its instances will be the deciding factor. If we don't take those into account, setting annotations in the index doesn't force the index to be saved in OCI format, so even though none of the indicators that would force use of the Docker format are present, we effectively throw away those annotations by using Docker format anyway. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
pkg/manifests.List: add SetSubject()/Subject()
Add methods for reading and writing the index-level "subject" field. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
pkg/manifests.List: use pointers in SetArtifactType()/ArtifactType()
... so that `nil` can be used to mark that we want to change the field in the image index as a whole rather than on one of the manifests that we're tracking. This is an API change. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
ibimage/manifests.list.Add(): don't read platform info for artifacts
If an instance being added to a list has a non-empty ArtifactType value or a config.MediaType value that isn't one of the known kinds of image configuration blobs, don't try to parse the configuration blob to figure out the image's OS/Architecture/Variant information. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
libimage/manifests: manage artifact information, too
Track information about artifacts for which we're managing the artifact manifests. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
libimage/manifests.list.SaveToImage(): use ImageOptions
When saving information about a list, use an ImageOptions structure to create the whole thing at once, and only save individual data piece by piece if we need to. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
libimage/manifests.list: hold artifact manifests
Add an AddArtifact() method which will craft an artifact manifest which references one or more files and then add that manifest to the index. When we need to build a reference to a list that includes our artifact manifests, save the manifests and symlinks to their "layer" blobs along with the contents of inlined blobs in a per-image directory, and add references to those locations to the list of images we can search for manifests and blobs. Signed-off-by: Nalin Dahyabhai <[email protected]>
-
libimage.ManifestList.Inspect(): show artifact types and file lists
When listing instances in an image index, show their artifact types and the names of any files that they're tracking. Signed-off-by: Nalin Dahyabhai <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.