Add default volumes for hyperv #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not review or merge this yet. I need to verify it works locally before I have any confidence it works correctly. I cannot do this because common has been broken most of the day and podman main branch is also broken. Pushing here as a place holder. |
baude
force-pushed
the
hypervdefaultvolume
branch
from
7bda9d2
to
0ef18f7
Compare
|
I would say this is reviewable but do not merge ... |
Luap99
reviewed
Feb 6, 2024
mheon
reviewed
Feb 9, 2024
All machine providers except WSL should have default volumes defined. HyperV was empty meaning no defaults were being added. For HyperV, like Linux, I think $HOME is sufficient. Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
hypervdefaultvolume
branch
from
0ef18f7
to
b8edf2b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All machine providers except WSL should have default volumes defined. HyperV was empty meaning no defaults were being added. For HyperV, like Linux, I think $HOME is sufficient.