Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ConfigureTimeZone for all Unix based platforms #1818

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 23, 2024

[NO NEW TESTS NEEDED]

Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I find such PRs hard to review. There is no test, no information on why this is needed, and no linked vendor PR (e.g., to Podman) to know where it may be used.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is related to containers/podman#21332?
In this case this is straight up breaking freebsd timezone support as the old code was used for freebsd as well and now you turn it into a NOP.

So remove the linux only tag and have to existing code work for freebsd as well.

@rhatdan
Copy link
Member Author

rhatdan commented Jan 24, 2024

I tried to do a test, but the function in timezone is difficult to test outside of container.
Moved this to be supported on non-windows platforms.

@rhatdan rhatdan changed the title add ConfigureTimeZone for non linux platforms add ConfigureTimeZone for all Unix based platforms Jan 24, 2024
@rhatdan
Copy link
Member Author

rhatdan commented Jan 24, 2024

@Luap99 PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan added the lgtm label Jan 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4b53eca into containers:main Jan 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants