New global option interface_name in containers.conf #1814
Conversation
|
You must sign your commits. @Luap99 PTAL |
|
Can we have this PR reviewed? The corresponding podman PR, too, is ready containers/podman#21318 waiting for this one. |
Yes, falls back to the existing ethX pattern as mentioned in the podman PR and the new test cases developed in there. |
|
Review comments incorporated. |
Add a new containers.conf attribute to define how to set interface name inside containers. Relates to: containers/podman#21313 Signed-off-by: Vikas Goel <[email protected]>
|
@Luap99 , please review. |
|
@mheon PTAL |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vikas-goel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
podman 5.0 Next month. |
|
@vikas-goel I let you once the version is updated in podman then you can rebase your podman PR, it should be sometime next week. |
|
Thanks @Luap99 |
Add a new containers.conf attribute to define how to set interface name inside containers.
Related to containers/podman#21313
Signed-off-by: Vikas Goel [email protected]