Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.57] backport: #1775 #1810

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

sohankunkerkar
Copy link
Member

I discussed this with @TomSweeneyRedHat on Slack and opened a backport PR to get this functionality in v0.57.

…ainers

This PR consolidates common functionality used by CRI-O and Podman
in one central location. I aimed to keep this change more generic,
considering that CRI-O and Podman have different ways for the file
mounting and applying security labels.

Signed-off-by: Sohan Kunkerkar <[email protected]>
@TomSweeneyRedHat
Copy link
Member

For easier reference:

#1775

This PR consolidates common functionality used by CRI-O and Podman in one central location. I aimed to keep this change more generic, considering that CRI-O and Podman have different ways for the file mounting and applying security labels.

Related to containers/podman#21063 (comment)

@rhatdan
Copy link
Member

rhatdan commented Feb 1, 2024

Since this change will not be used by Podman, only the main branch.
/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 963608a into containers:v0.57 Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants