Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(machine): add applehv and hyperv host type #1749

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

BlackHole1
Copy link
Contributor

@BlackHole1 BlackHole1 commented Nov 24, 2023

Add AppleHV and HyperV host type

pkg/machine/machine.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented Nov 24, 2023

@baude @jakecorrenti @ashley-cui PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need a hyperV type too?

@baude
Copy link
Member

baude commented Nov 26, 2023

commit message ?

Copy link
Member

@jakecorrenti jakecorrenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once a commit and PR message are added, as well as the HyperV type, this will lgtm.

Add AppleHV and HyperV host type

Signed-off-by: Black-Hole1 <[email protected]>
@BlackHole1 BlackHole1 changed the title refactor(machine): add applehv host type refactor(machine): add applehv and hyperv host type Nov 27, 2023
@BlackHole1
Copy link
Contributor Author

Once a commit and PR message are added, as well as the HyperV type, this will lgtm.

Done

@rhatdan
Copy link
Member

rhatdan commented Nov 27, 2023

LGTM

@baude
Copy link
Member

baude commented Nov 27, 2023

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, BlackHole1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 082c2ed into containers:main Nov 27, 2023
7 checks passed
@BlackHole1 BlackHole1 deleted the add-apphv-host-type branch November 28, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants