Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: support no-dereference mount option #1747

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Nov 20, 2023

Requries crun 1.11+ where the option is called copy-symlink.
Required in containers/podman/pull/20356.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg marked this pull request as ready for review November 21, 2023 09:29
@vrothberg
Copy link
Member Author

@flouthoc @Luap99 PTAL

@vrothberg
Copy link
Member Author

@umohnani8 PTAL

@vrothberg
Copy link
Member Author

The option is now called no-dereference but crun is using copy-symlink.

@giuseppe
Copy link
Member

giuseppe commented Nov 21, 2023

I preferred copy-symlink as there is a smaller chance in the future that the kernel is going to add a similar option to the mount syscall. no-dereference seems more likely to clash

@vrothberg
Copy link
Member Author

I preferred copy-symlink as there is a smaller chance in the future that the kernel is going to add a similar option to the mount syscall. no-dereference seems more likely to clash if a similar

Totally agree 👍 I just wanted to explain the name change because I used copy-symlink in an earlier version of this commit.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit to state the new actual name not copy-symlink.

Requries crun 1.11+ where the option is called `copy-symlink`.
Required in containers/podman/pull/20356.

Part-of: issues.redhat.com/browse/RUN-1935
Signed-off-by: Valentin Rothberg <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg changed the title parse: support copy-symlink option parse: support no-dereference mount option Nov 21, 2023
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,giuseppe,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d54dcfe into containers:main Nov 21, 2023
7 checks passed
@vrothberg vrothberg deleted the RUN-1935 branch November 21, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants