Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: use GetRuntimeDir() from c/storage #1725

Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Nov 2, 2023

needs: containers/storage#1740

Signed-off-by: Giuseppe Scrivano [email protected]

pkg/util/util_supported.go Outdated Show resolved Hide resolved
@giuseppe giuseppe force-pushed the consolidate-xdg-runtime-code branch 2 times, most recently from 1582783 to 07cbc57 Compare November 7, 2023 14:07
pkg/config/default.go Show resolved Hide resolved
pkg/config/default.go Outdated Show resolved Hide resolved
@giuseppe giuseppe force-pushed the consolidate-xdg-runtime-code branch 3 times, most recently from d37afee to aaa572a Compare November 15, 2023 18:36
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rhatdan
Copy link
Member

rhatdan commented Nov 20, 2023

Should this be moved out of draft?

go.mod Outdated Show resolved Hide resolved
@giuseppe giuseppe marked this pull request as ready for review November 21, 2023 06:30
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit fffffcb into containers:main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants