layer tree: be more resilient #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make operating on the layer tree more resilient towards parallel image removals by checking for unknown-image errors. This partially fixes below linked BZ. At the time of writing, I do not have a reliable easy (and short running) reproducer. Hence, I suggest to merge this change without tests and rely on either Podman CI (which doesn't have a reliable test yet either) and the QE team (will be informed). BZ: bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Working on a system test atm |
|
good to merge from my end |
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 23, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 which does the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
|
containers/podman#18980 has a regression test ✔️ |
|
/lgtm |
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 23, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 which does the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 which does the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 which does the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 which does the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/libpod
that referenced
this pull request
Jun 26, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 12, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this pull request
Jul 12, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 13, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this pull request
Jul 13, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 17, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 17, 2023
Handle more TOCTOUs operating on listed images. Also pull in containers/common/pull/1520 and containers/common/pull/1522 which do the same on the internal layer tree. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2216700 Signed-off-by: Valentin Rothberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make operating on the layer tree more resilient towards parallel image removals by checking for unknown-image errors. This partially fixes below linked BZ.
At the time of writing, I do not have a reliable easy (and short running) reproducer. Hence, I suggest to merge this change without tests and rely on either Podman CI (which doesn't have a reliable test yet either) and the QE team (will be informed).
BZ: bugzilla.redhat.com/show_bug.cgi?id=2216700
@Luap99 @giuseppe @rhatdan PTAL