libnetwork/netavark: fix ipam allocation for custom lease range #1510
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mheon PTAL |
LeaseRange allows to set a custom start and end ip for our allocator. However in this case the allocator ignored that fact the the first ip (network ip) and the last ip (broadcast address only valid for ipv4) cannot be used. These ips are special and should never be assigned. Interestingly the kernel allows to assign the broadcast address to a interface so it would appear to be working and no error was reported. Only the attempts to make a connection failed. Fixes containers/podman#18906 Signed-off-by: Paul Holzinger <[email protected]>
|
LGTM @flouthoc PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LeaseRange allows to set a custom start and end ip for our allocator. However in this case the allocator ignored that fact the the first ip (network ip) and the last ip (broadcast address only valid for ipv4) cannot be used. These ips are special and should never be assigned.
Interestingly the kernel allows to assign the broadcast address to a interface so it would appear to be working and no error was reported. Only the attempts to make a connection failed.
Fixes containers/podman#18906