Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netavark: add bclim option for macvlan #1474

Merged
merged 1 commit into from
May 25, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented May 24, 2023

@Luap99
Copy link
Member Author

Luap99 commented May 24, 2023

@mheon @flouthoc PTAL

@mheon
Copy link
Member

mheon commented May 24, 2023

LGTM

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented May 25, 2023

/hold merge conflict

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the lgtm label May 25, 2023
@rhatdan
Copy link
Member

rhatdan commented May 25, 2023

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit fae9740 into containers:main May 25, 2023
6 checks passed
@Luap99 Luap99 deleted the bclim branch May 25, 2023 11:15
Luap99 added a commit to Luap99/libpod that referenced this pull request May 25, 2023
Luap99 added a commit to Luap99/libpod that referenced this pull request Jun 13, 2023
cgiradkar pushed a commit to cgiradkar/podman that referenced this pull request Jul 12, 2023
cgiradkar pushed a commit to cgiradkar/podman that referenced this pull request Jul 13, 2023
cgiradkar pushed a commit to cgiradkar/podman that referenced this pull request Jul 17, 2023
cgiradkar pushed a commit to cgiradkar/podman that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants