pkg/config: new fields for better pasta integration #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
Users way wish to configure a set of default options that should be used when running pasta. Options that are given on the cli will be appended, however the implementation of this needs to happen in podman. For slirp4netns we already support the network_cmd_options field. Signed-off-by: Paul Holzinger <[email protected]>
Add a new field to the network section to allow users to set the default network program which is used when running rootless containers. This should be used when you run something like --network private or --network default as rootless user. The current default is slirp4netns so we keep that for now. Once I integrate pasta in the rootless netns then we can consider switching the default to pasta. This setting will also be useful then for distros who may not ship pasta so that they could set it back to slirp if needed. Signed-off-by: Paul Holzinger <[email protected]>
|
@vrothberg PTAL |
Sure you could reuse it but that just breaks completely if users want to use both --network slirp4netns and --network pasta for different containers at the same time. |
|
Thanks, sounds like a legit use case! /hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/config: add pasta_options field
Users way wish to configure a set of default options that should be used
when running pasta. Options that are given on the cli will be appended,
however the implementation of this needs to happen in podman.
For slirp4netns we already support the network_cmd_options field.
pkg/config: add default_rootless_network_cmd field
Add a new field to the network section to allow users to set the default
network program which is used when running rootless containers.
This should be used when you run something like --network private or
--network default as rootless user.
The current default is slirp4netns so we keep that for now. Once I
integrate pasta in the rootless netns then we can consider switching the
default to pasta.
This setting will also be useful then for distros who may not ship pasta
so that they could set it back to slirp if needed.